This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix DecoderNLS.Convert to out the correct value for 'completed' #27210
+10
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a complementary fix to https://github.com/dotnet/coreclr/issues/23020
tarekgh
approved these changes
Oct 15, 2019
GrabYourPitchforks
added a commit
that referenced
this pull request
Oct 17, 2019
Port #27210 to release/3.1
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corefx
that referenced
this pull request
Nov 15, 2019
…et#27229) Port dotnet/coreclr#27210 to release/3.1 Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/dotnet/coreclr/issues/27191. Unit tests are in corefx and will be updated there.
I might need to suppress some test failures in coreclr as a result of this change. Will wait for CI to get the full list.